Fix local API comments for age-restricted videos #3760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Jul 10, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 10, 2023
This comment was marked as spam.
This comment was marked as spam.
PikachuEXE
approved these changes
Jul 11, 2023
github-actions
bot
removed
the
PR: waiting for review
|
@efb4f5ff-1298-471a-8973-3d47447115dc That was very much expected, I designed the android format extraction to log an error as soon as anything was wrong with the response and then to not use said response, because when YouTube breaks the android client they go for it (the idea was that if YouTube broke it, the watch page would still work, just throttled instead of failing entirely. That's why it logged an error with as much information as possible to the console, instead of showing an error toast). As the android formats were removed in #3759 anyway, it's a none issue now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix local API comments for age-restricted videos
Pull Request Type
Related issue
closes #3738
Description
As the bypassed response comes from an embed client, it doesn't have extras like comments and the watch next feed, so we need to check if the video has comments before switching to the bypassed result.
Screenshots
before:
after:
Testing
Test some age restricted videos like this one mentioned in the issue https://youtu.be/rrSnnhe53ks or the videos in this playlist: https://www.youtube.com/playlist?list=PLze6c8Dxpjv4eaemhVXYLURZt3Pcrddw5